fix(git): limit 1Password signing key read to macOS only#83
Merged
Conversation
EC2 also has op CLI (has_op=true) but lacks the private key matching the 1Password signing key, causing ssh-keygen to fail with "error in libcrypto". Restrict to darwin where op-ssh-sign can access the key via 1Password SSH agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
op://Dotfiles/Git/signing_key) to macOS only (eq .chezmoi.os "darwin")opCLI installed (has_op=true) but lacks the matching private key, causingssh-keygento fail witherror in libcrypto~/.ssh/id_github.pubfile path as intendedTest plan
chezmoi execute-template < .chezmoi.yaml.tmplreads signing key from 1Passwordchezmoi execute-template < .chezmoi.yaml.tmplleaves signing_key empty